NewInstance

Welcome to anti-refactoring lesson 2.

There are painters that paint with pencils or brushes and painter that paints with a bucket. A bucket is very effective if you just want a canvas filled. An example:

1    private String prefix;
2    public String getPrefix(){
3        return getClass().getPackage().getName();
4    }
5    public void setPrefix(String prefix) {
6        this.prefix = prefix;
7    }

Neat! I don't even think that an IDE can produce dumb stuff like this: set a value, and ignore it. Remembering the principle of the minimum surprise...

Fortunately Eclipse warned me that prefix is never used; in a complete mess like the one I am getting Eclipse is an invaluable ally. Slowly cleaning up...